Make test run on german locale. #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
douglascrockford
added a commit
that referenced
this pull request
Apr 13, 2012
Make test run on german locale.
|
Thanks. |
|
Thanks for merging so fast! We are amazed. |
BGehrels
pushed a commit
to BGehrels/JSON-java
that referenced
this pull request
Apr 29, 2020
updates Test cases to support new JSONML and XML conversion options
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Douglas,
Out of the box the test failed with the exception below. We think it may be because of my German locale. Our change makes the test green.
Thanks for providing the code!
Cheers,
Bernhard & Görge
java.util.MissingResourceException: Can't find bundle for base name org.json.tests.SampleResourceBundle, locale en
at java.util.ResourceBundle.throwMissingResourceException(ResourceBundle.java:1427)
at java.util.ResourceBundle.getBundleImpl(ResourceBundle.java:1250)
at java.util.ResourceBundle.getBundle(ResourceBundle.java:952)
at org.json.JSONObject.(JSONObject.java:321)
at org.json.tests.TestJSONObject.testConstructor_UsResourceBundle(TestJSONObject.java:690)